This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Added support for Node v12 by ensuring Gulp uses correct gracef…#62
Open
ehsan-yaqubi wants to merge 1 commit intowebsite-scraper:masterfrom
Open
Added support for Node v12 by ensuring Gulp uses correct gracef…#62ehsan-yaqubi wants to merge 1 commit intowebsite-scraper:masterfrom
ehsan-yaqubi wants to merge 1 commit intowebsite-scraper:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for Node v12 without removing support for old
npmversions, I mean, unlike the other PR (which needsnpm v8.3.0orpnpm), my PR works even withnpm v6.11.3(which's the version I tested with).Basically, only Gulp had issues with Node v12 which were fixed by ensuring Gulp uses correct
graceful-fsversion.See also https://stackoverflow.com/a/58394828